Skip to content

Add model streaming functions #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 14, 2024
Merged

Add model streaming functions #3611

merged 7 commits into from
Aug 14, 2024
+258 −3

Conversation

TheNormalnij
Copy link
Member

@TheNormalnij TheNormalnij commented Jul 27, 2024 •
edited
Loading

For #3266

bool engineStreamingRequestModel(number modelId [, bool addReference = false, bool isBlocking = false ])
-- Returns true if model was requested, false otherwise.

bool engineStreamingReleaseModel(number modelId [, bool removeReference = false ])
-- Returns true if model was unloaded, false otherwise.

string engineStreamingGetModelLoadState(number modelid)
-- Returns 'unloaded' | 'loaded' | 'requested' | 'finishing' | 'reading'

@TheNormalnij TheNormalnij added the enhancement New feature or request label Jul 27, 2024
@TheNormalnij TheNormalnij added this to the 1.6.1 milestone Jul 27, 2024
@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Jul 27, 2024 •
edited
Loading

Can you explain for noobs what addReference and isBlocking arguments are for?

Also, for #3266 couldn't these functions be called automatically, leaving this responsibility to MTA and not the developer? Would this be problematic?

@TheNormalnij
Copy link
Member Author

TheNormalnij commented Jul 27, 2024 via email

@TheNormalnij TheNormalnij marked this pull request as ready for review July 28, 2024 13:49
FileEX
FileEX suggested changes Jul 31, 2024
View reviewed changes
@Dutchman101 Dutchman101 merged commit 008eaa7 into multitheftauto:master Aug 14, 2024
6 checks passed
@Dutchman101 Dutchman101 mentioned this pull request Aug 14, 2024
Merged
MTABot pushed a commit that referenced this pull request Aug 14, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
9f65bc6 
008eaa7 Add model streaming functions (#3611)
@TheNormalnij TheNormalnij deleted the TheNormalnij/requestStreaming branch August 28, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FileEX FileEX FileEX requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@TheNormalnij @Fernando-A-Rocha @FileEX @Dutchman101